kubernetes-sigs / external-dns / 35574836257
82%

DEFAULT BRANCH: master
Ran
Jobs 2
Files 158
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 81.916% (-0.03%) from 81.948%
35574836257

push

github

web-flow 
refactor(source)!: skipper-routegroup refactored to use client-go informers (#6714)

* refactor(source)!: skipper-routegroup refactored to use client-go informers instead of hand rolled client. Use of `.Metadata` in FQDN templates is **deprecated**. Note that you need to have RouteGroup CRD installed in your cluster or `--source=skipper-routegroup` will lead to failing start of external-dns.
docs(source): skipper-routegroup add guide similar to other custom sources

Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>

* cleanup cfg.SkipperRouteGroupVersion

Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>

* fix test after rebase

Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>

* cleanup consts

Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>

* go mod tidy

Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>

* fix(source): fail fast when the RouteGroup CRD is missing

Probe the API once before starting the informer. A missing CRD previously
only surfaced as a WaitForCacheSync timeout a minute into startup.

Also drops the write-only annotationFilter/labelSelector fields from
routeGroupSource, restores TestRouteGroupAddEventHandler, and documents the
CRD requirement, the watch RBAC verb and the .Metadata deprecation.

Signed-off-by: Michel Loiseleur <michel.loiseleur@traefik.io>

* Apply suggestion from @mloiseleur

---------

Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
Signed-off-by: Michel Loiseleur <michel.loiseleur@traefik.io>
Co-authored-by: Michel Loiseleur <michel.loiseleur@traefik.io>
Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>

15587 of 19028 relevant lines covered (81.92%)

1445.08 hits per line

Coverage Regressions

Lines Coverage ∆ File
35
77.7
0.18% store.go
6
94.83
2.56% skipper_routegroup.go
Jobs
ID Job ID Ran Files Coverage
1 run-ubuntu-latest - 35574836257.1 158
81.92
GitHub Action Run
2 run-macos-latest - 35574836257.2 158
81.92
GitHub Action Run
Source Files on build 35574836257