cameri / nats-server / 35562382724
82%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 66
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 81.19% (-1.4%) from 82.592%
35562382724

push

github

web-flow 
[FIXED] Remove stale JetStream account usage after peer removal (#8570)

Fixes #8563.

When a JetStream server is permanently removed from the cluster, its
last reported account usage can remain in `jsAccount.rusage`. Because
that value is still included in the account totals, replacing a stream
replica on another server can cause storage usage to be counted twice.

I reproduced this with a 4-node cluster and an R3 stream. After removing
one of the replica-holding servers and letting the stream move to the
spare node, the stream was still correctly running with 3 replicas, but
the account storage usage increased as if there were 4 copies.

This change removes the departed server's usage when its meta peer
removal is committed. It also ignores a late usage update from the
removed node so that the stale entry cannot be added back after cleanup.

I added a regression test that:

* creates an R3 stream on a 4-node cluster,
* verifies the initial account usage,
* removes one of the servers hosting a replica,
* waits for the replica to move to the spare server,
* verifies the account usage stays unchanged,
* and checks that a late usage update from the removed peer does not
recreate the stale entry.

Testing:

* new regression test passes repeatedly
* regression test passes with `-race`
* related peer-removal and account-usage tests pass
* `go vet ./server`
* `git diff --check`

70175 of 86433 relevant lines covered (81.19%)

318236.75 hits per line

Coverage Regressions

Lines Coverage ∆ File
593
63.64
 -14.13% src/github.com/nats-io/nats-server/server/opts.go
134
62.02
 -28.76% src/github.com/nats-io/nats-server/server/msgtrace.go
99
61.26
 -6.2% src/github.com/nats-io/nats-server/server/reload.go
84
90.98
 -2.0% src/github.com/nats-io/nats-server/server/client.go
61
78.17
 -1.23% src/github.com/nats-io/nats-server/server/raft.go
61
81.94
 -2.84% src/github.com/nats-io/nats-server/server/route.go
59
78.11
 -0.52% src/github.com/nats-io/nats-server/server/filestore.go
52
84.12
 -7.0% src/github.com/nats-io/nats-server/server/parser.go
39
85.6
 -0.52% src/github.com/nats-io/nats-server/server/stream.go
33
88.34
 -1.02% src/github.com/nats-io/nats-server/server/server.go
22
84.41
 -1.12% src/github.com/nats-io/nats-server/server/events.go
22
83.2
 0.07% src/github.com/nats-io/nats-server/server/jetstream_cluster.go
21
85.9
 -0.58% src/github.com/nats-io/nats-server/server/accounts.go
14
87.45
 -0.15% src/github.com/nats-io/nats-server/server/consumer.go
12
10.38
 -11.32% src/github.com/nats-io/nats-server/server/signal.go
9
86.65
 -0.76% src/github.com/nats-io/nats-server/server/auth.go
9
73.95
 1.05% src/github.com/nats-io/nats-server/server/jetstream_api.go
9
72.96
 -5.66% src/github.com/nats-io/nats-server/server/log.go
8
74.42
 -4.65% src/github.com/nats-io/nats-server/server/jwt.go
6
93.47
 -0.29% src/github.com/nats-io/nats-server/server/gateway.go
6
89.32
 0.04% src/github.com/nats-io/nats-server/server/leafnode.go
5
91.9
 -0.72% src/github.com/nats-io/nats-server/server/jetstream_batching.go
2
90.3
 -0.19% src/github.com/nats-io/nats-server/server/sublist.go
1
76.56
 -1.56% src/github.com/nats-io/nats-server/server/errors.go
1
81.05
 -0.05% src/github.com/nats-io/nats-server/server/memstore.go
1
86.59
 0.22% src/github.com/nats-io/nats-server/server/monitor.go
1
88.63
 0.08% src/github.com/nats-io/nats-server/server/mqtt.go
Jobs
ID Job ID Ran Files Coverage
1 35562382724.1 66
81.19
 GitHub Action Run
Source Files on build 35562382724