umputun / agterm / 35542263916

93%

push

github

fix(control): report a present socket owner and reject failed fixture clients (#633)

* fix(control): clarify refused socket connections

`SocketClient.connect` answered every failure with `is agterm running?`, and Darwin refuses a live listener whose backlog is full with the same ECONNREFUSED a socket nobody listens on returns, so the #606 reporter read the refusal as the app being gone. On a refusal the CLI now checks the server's ownership lock on `<socket>.lock` with `F_GETLK`, which observes a flock without competing for it, so the probe cannot fail a starting instance's own `LOCK_EX|LOCK_NB`. A held lock says the owner is there and not answering. Anything else stays uncertain and says so. Every other errno keeps the old question.

* test(session-host): reject failed fixture clients

a client killed before writing stdout looked like a successful empty reply. Require a normal zero exit and report the executable, exit status or signal, and stderr on failure.

oversized-request rejection can close the socket during a write. Suppress SIGPIPE and treat EPIPE, ECONNRESET and ENOTCONN as peer closure so expected rejections still exit normally.

* fix(control): probe the ownership lock for a missing socket too

a running app can hold its ownership lock while its socket is missing or refusing connections. Probe on ENOENT as well as ECONNREFUSED, using the same hint for both. A held lock establishes an owner, not why the socket is unreachable.

share the ownership-lock path through `ControlResolve.ownershipLockPath` so the server and CLI cannot silently use different lock files.

* test(session-host): report daemon creation failure details

the suite's only real-host daemon spawn recorded a bare "daemon was not created", so a CI failure identified no stage. Report the replies and the host log from that guard.

27 of 34 new or added lines in 3 files covered. (79.41%)

12900 of 13842 relevant lines covered (93.19%)

2948069.97 hits per line