bleedingdeacons / sentinel / 35540009947

91%

Build Type

push

github

Committed by web-flow

Commit Message

feat!: move to PHP 8.4/8.5 and PHPUnit 13, tested to WP 7.1.1 (#55)

Part of the suite-wide PHP 8.5 / WordPress 7.1.1 upgrade.

- Requires PHP 8.1 -> 8.4, header and readme.txt. WordPress 7.1
  recommends 8.4/8.5, and PHPUnit 13 requires >= 8.4.
- PHPUnit ^10.5 -> ^13.0, with all 170 docblock annotations converted
  to attributes (161 @test, 7 @covers, 2 @dataProvider). PHPUnit 12
  removed doc-comment metadata outright. Converted with Rector; the
  counts match the originals exactly.
- bleedingdeacons/wp-mocks ^2.0 -> ^3.0, the release that raises that
  package's own floor to 8.4 and allows PHPUnit 13.
- CI runs a matrix of 8.4 and 8.5 rather than a single 8.1. The build
  archive, both badge assertions and the Coveralls upload are pinned to
  the 8.4 leg: they are identical on both, and running them on each has
  the two legs writing the same paths at once.
- PHPStan analyses a min/max range instead of one pinned version. A
  single pin proves one end only -- at the ceiling it misses an
  8.5-only construct that breaks on 8.4, at the floor it misses what
  8.5 deprecates.
- readme.txt Tested up to -> 7.1.1.

Verified with the same gate sequence ci.yml runs, on PHP 8.5.7:
composer validate, audit, php -l, PHPStan level 8, PHPUnit, PHPCS and
build:production. The test count is unchanged, which is the check that
matters -- a mis-mapped @covers moves coverage attribution without
failing anything.

Also removes the suite's one genuine language-level deprecation:
src/Logger/sentinel-logger.php mapped E_STRICT, deprecated in PHP 8.4 and
removed in PHP 9. It survived because that file is excluded from both
PHPStan and PHPCS. While in the same handler, the `@` suppression check is
repaired: `error_reporting() === 0` has not fired since PHP 8.0, which made
the operator set a non-zero mask rather than zero, so suppressed errors were
being logged anyway. It now tests the mask against the error.

BREAKING CHANGE: requires PHP 8.4 or later.

Coverage Stats

0 of 1 new or added line in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

1711 of 1887 relevant lines covered (90.67%)

4.51 hits per line