panates / postgrejs / 35531760901

98%

master: 89%

push

github

test: skip the types PostgreSQL 12 does not have

Eighteen failures in CI's oldest matrix entry, all of them the same
thing: types added after 12. `xid8` and `pg_snapshot` arrived in 13, the
multiranges and `regcollation` in 14, and the specs written for them this
week were only ever run against 18.

The gates ask the server whether the type exists - `to_regtype('xid8') is
not null` - rather than comparing a version number. It is exact, and it
does not have to be kept in step with the release notes when a type moves
between versions.

`23-type-oid-table.spec.ts` needed more than a skip: its whole job is to
check every entry, so skipping it on 12 would have left the table
unverified there. It now indexes pg_type by name as well as by OID. An
entry whose OID is absent is checked by name instead: if the name is
there, the OID is wrong and it fails; if neither is there, the server
simply predates the type and there is nothing to check. That is a
stronger test than before rather than a weaker one - it now catches a
mistyped OID *and* a mistyped name - and it was verified by breaking one
of each against a live PostgreSQL 12:

    pg_lsn: 3220 -> 3221    "pg_lsn = 3221 is really \"_pg_lsn\""
    inet: 869 -> 99999      caught through the name index

A new first assertion checks the catalog read returned something, so a
query that silently returns nothing cannot make the rest pass by having
nothing to check.

One range test checked a tstzrange and a multirange in the same body; the
multirange half moved into the gated block so the rest still runs on 12.

Verified against a PostgreSQL 12.22 container: 1535 passing, 0 failing.
18.4 is unchanged at 1582.

3243 of 3435 branches covered (94.41%)

Branch coverage included in aggregate %.

16524 of 16734 relevant lines covered (98.75%)

369.65 hits per line