eclipse-aascw / aas-core-codegen / 35530445776

90%

Build Type

push

github

Committed by web-flow

Commit Message

Polish JSON and XML de/serialization (#738)

We made a sweep over all the targets to prepare them for JSON-value
(value-only) de/serialization. This change contains all the minor fixes
and refactorings which simplify and re-group the de/serializations.

C++. The error paths in the verification were built back to front: the
statements run deepest-segment-first, so appending them rendered
``[3].some_property`` where ``.some_property[3]`` was meant. This was
introduced in #653 and stayed invisible while the single-segment paths
dominated.

C#, the JSON serialization. Every property was written out as
a statement of its own, guarded by a ``try``/``catch`` only where
``reaches_a_number``, which was buggy and not fool proof.

Every property now goes through one ``SetProperty<T>`` instead, which
holds the handler once and prepends the property there.

The serializer has to be handed over as a value, and a method
group converted to a delegate allocates on every conversion under
``LangVersion 8``, so it comes from a cached ``Serializer<T>`` field,
beside the ones the lists and the tuples already had. The fields are keyed
by the serializer and not by the type -- every class goes through
``TransformIClass``, a named union through ``TransformIUnion`` and
a constrained primitive through the ``ToJsonValue`` of its constrainee --
and ``Serializer<in T>`` is contravariant, so the field is declared on the
general type.

The path names the C# property, and not the JSON one, and renders through
a new ``Reporting.GenerateCSharpPath``: a serialization error answers
a call the caller made on an *instance*, which they hold, and not on
a document which has not been written yet.

``{Enum}ToJsonValue`` used to let an invalid literal escape as a raw
``System.ArgumentException``, although ``ToJsonObject`` documents
a ``SerializationException``. It raises a ``SerializationFailure`` like
everything else now.

C#, the XML serialization. The writer threw ``ArgumentException`` with
n... (continued)

Coverage Stats

186 of 187 new or added lines in 16 files covered. (99.47%)

3 existing lines in 2 files now uncovered.

35244 of 40574 relevant lines covered (86.86%)

2.61 hits per line