umputun / revdiff / 35529893286

92%

push

github

Add --filter-unreviewed (#366)

* feat(ui): add --filter-unreviewed

let scripted launches enable the unreviewed filter without a manual F keypress.
The preference is also available through REVDIFF_FILTER_UNREVIEWED and the
filter-unreviewed config key.

clear the filter when a load leaves one underlying file, since F cannot
disable it in single-file mode. This also fixes the filter getting stuck
after a reload reduces the review to one file. Reloads preserve a manual
choice to turn the filter off.

Fixed #365

* docs: list --filter-unreviewed in the launcher usage headers

* fix(launchers): avoid stderr leaks from abandoned herdr reviews

a dispatched review can outlive its launcher and open stderr after the launcher
has removed the capture, recreating a file nobody will delete. Give the child its
own hard link to the capture and remove that alias before publishing the exit
code. If the launcher removes the capture before the child acquires its link, the
review continues with stderr directed to /dev/null.

the herdr command string is built from the invocation that already carries the
EDITOR/VISUAL prefix, so a dispatched review still starts with the caller's editor
environment.

a regression test forces the launcher to exit between the started marker and the
stderr open, then checks cleanup after the child finishes. A second one strips
EDITOR and VISUAL at the dispatch boundary, where the launcher's own environment
would otherwise mask what it forwards.

12 of 12 new or added lines in 3 files covered. (100.0%)

11888 of 12980 relevant lines covered (91.59%)

3508.48 hits per line