CyclopsMC / CyclopsCore / 35527050459

31%

master-1.21: 31%

Pull #245

github

Fix DeferredHolderCommon delegates not being references on Forge

Registry#safeCastToReference only accepts Holder.Reference, which is why
DeferredHolderCommon exposes its bound holder as delegate. On Forge, the
IForgeRegistry bind override ran before the regular registry lookup and
bound to Holder.direct, so the delegate was never a reference and
serialization kept failing there.

The regular registry is now consulted first, and the Forge override
prefers the registry's own delegate. Covered by game tests on all
loaders.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WyxzX1DGvXj5nV4zew3V8u

1320 of 4625 branches covered (28.54%)

Branch coverage included in aggregate %.

3942 of 12125 relevant lines covered (32.51%)

1.59 hits per line