CyclopsMC / IntegratedDynamics / 35526631254

48%

master-1.21-lts: 48%

Pull #1742

github

Stop a shift-click from crafting a copied variable card away again

Taking the result of a variable card copy with shift-click left the player with
one written card and one blank card, instead of two written cards.

A copy leaves a card holding the copied variable behind in the crafting grid,
and a lone variable card is what the recipe that clears variable cards matches.
Shift-clicking crafts until the result changes item, and both recipes produce a
variable card, so the game immediately crafted the copy away again.
The copy is now handed to the player who crafts it, which leaves the grid empty
and ends the shift-click there. An automated crafter still gets it back as a
remaining item.

Driving a dev client with clientdevbridge is what turned this up: the crafting
game test could not reproduce it, since the result slot only recomputes
mid-craft for a real server player.

Closes #725

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PH2a9RG8LcsbT2oMGVzKrW

3442 of 9784 branches covered (35.18%)

Branch coverage included in aggregate %.

13655 of 25746 relevant lines covered (53.04%)

2.54 hits per line