polserver / polserver / 35520847132

82%

Build Type

push

github

Committed by web-flow

Commit Message

Send the quest arrow id in network order, like the rest of its packet (#974)

SendQuestArrow() wrote the arrow id with Write<u32> while every other field of
the 0xBA packet uses WriteFlipped. The client reads all four fields through
ntohs/ntohl, so it saw the id byte reversed. It matched that reversed value
against its own reversed copy, so arrows still raised and cleared; what broke
was the wire, where a packet log, an assistant or an outgoing packet hook saw
an id the call never returned.

The test client's decoder had been written to match the core, comment and all.
It now reads the field the same way as the rest of the packet, which is what
keeps sendfuncs_quest_arrow green across the change.

Coverage Stats

2 of 2 new or added lines in 1 file covered. (100.0%)

6 existing lines in 4 files now uncovered.

60029 of 73425 relevant lines covered (81.76%)

1553097.22 hits per line