Chia-Network / chia-blockchain / 35512708893

90%

Build Type

push

github

Committed by web-flow

Commit Message

Retype BlockGenerator.program from SerializedProgram to bytes (#21405)

* Retype BlockGenerator.program from SerializedProgram to raw bytes

BlockGenerator.program (and NewBlockGenerator) was typed as
SerializedProgram, which chia_rs deliberately refuses to parse if the
bytes are ever a future non-classic-CLVM encoding (e.g. serde_2026).
Every producer eagerly called SerializedProgram.from_bytes() on the
generator bytes, and every consumer that didn't need a Program just
called bytes(...) on it again.

Retype .program as plain bytes, and only wrap it back into a
SerializedProgram at the handful of call sites that genuinely need a
Program object because they run it or hand it to a chia_rs function
that only accepts one: get_spends_for_trusted_block(),
get_spends_for_trusted_block_with_conditions(),
get_puzzle_and_solution_for_coin(), compute_block_cost(), and the v0
UnfinishedBlock.transactions_generator field.

This also fixes a latent bug in get_block_generator(): it used to call
get_transactions_generator_program(), which ran
SerializedProgram.from_bytes() on the generator bytes and would raise
ValueError for a valid post-HF2 (serde_2026) generator, silently
rejecting the block via the try/except in
multiprocess_validation.py. Deleted get_transactions_generator_program
since nothing needs it anymore.

No behavior change for v0 blocks: verified via targeted test runs.

🤖 Generated with Cursor

Co-authored-by: Cursor <cursoragent@cursor.com>

* Add explicit GeneratorFormat to BlockGenerator

Addresses Arvid's review of #21405. `program: bytes` alone throws
away whether the bytes are classic CLVM or serde_2026. Richard's call
was a chia-blockchain-local tag, not widening SerializedProgram (that
was already rejected for chia_rs, see the generator-format-type-spike
report).

Adds `GeneratorFormat` (CLASSIC=0, SERDE_2026=1, mirroring the
existing version=0/1 convention) and a `format: GeneratorFormat`
field on `BlockGenerator`/`NewBlockGenerator`, alongsi... (continued)

Coverage Stats

19950 of 24892 branches covered (80.15%)

Branch coverage included in aggregate %.

43 of 45 new or added lines in 17 files covered. (95.56%)

44 existing lines in 6 files now uncovered.

117097 of 126881 relevant lines covered (92.29%)

1.85 hits per line