CyclopsMC / IntegratedDynamics / 35511062893

57%

master-1.21-lts: 48%

Pull #1738

github

Resolve the next-major TODOs

A first release on a new Minecraft version is where the deferred API
breaks can land.

IPartType and IPartState: the 15 methods marked "make non-default in
nextmajor" become abstract. PartStateBase already implemented all eight
IPartState ones, so those only lose the interface default. Six of the
seven IPartType bodies move into PartTypeAdapter, the documented default
implementation, which already held onAspectVariablesChanged. Anything
extending PartTypeAdapter or PartStateBase is unaffected; only direct
implementors of the raw interfaces have to supply them now.

GameTestsWrenchConfig proxies IPartType and relied on
InvocationHandler#invokeDefault for snapshotConfig and applyConfig, which
only works on default methods. It now calls PartConfigHelpers directly
with the proxy as the part type, which is what those bodies did.

OperatorBuilders: FLUIDSTACK_3 was built from ITEMSTACK. That gave
OBJECT_FLUIDSTACK_WITH_DATA the itemstack kind, so it shared its unique
name with OBJECT_ITEMSTACK_WITH_DATA. OperatorRegistry stores those in a
plain map, so the fluid operator silently overwrote the item one, and the
fluid operator showed the item stack translation while
operator.integrateddynamics.fluidstack.withdata went unused. Both now
have their own identifier.

IIngredientChannelInsertPreConsumer: the deprecated three-argument insert
is gone, so the four-argument one is the only method. Its test moves onto
the current api, keeping the coverage of a pre-consumer that takes away
without claiming.

CableHelpers: the deprecated six-argument onCableRemoving is gone, all
callers already passed the seventh argument.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01V35MFZ7JSgoLe79J4d1uxf

3833 of 10079 branches covered (38.03%)

Branch coverage included in aggregate %.

21855 of 35043 relevant lines covered (62.37%)

3.22 hits per line