CyclopsMC / ColossalChests / 35509517077

64%

master-1.21: 62%

Pull #211

github

Fix the 14 upgrade/downgrade game tests on Fabric

The tests compared the result of ItemStack#useOn against the
InteractionResult.SUCCESS constant by identity. In 26.3, vanilla's
ItemStack#useOn no longer returns the item's result unchanged: for a
Success whose wasItemInteraction is set, it returns
success.heldItemTransformedTo(stack), a new Success record carrying the
held stack. So the constant never matches.

NeoForge and Forge patch useOn to route server-side use through
CommonHooks#onPlaceItemIntoWorld, which does not apply that
transformation, which is why only Fabric failed.

The upgrade tool itself was correct on all three loaders: it returned
SUCCESS and the chests were transformed. Only the assertion was too
strict, so it now checks for an InteractionResult.Success instead. The
two assertions on FAIL are left alone, since non-Success results are
still passed through unchanged.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01V35MFZ7JSgoLe79J4d1uxf

331 of 696 branches covered (47.56%)

Branch coverage included in aggregate %.

1724 of 2498 relevant lines covered (69.02%)

7.62 hits per line