thorstenalpers / Finance.NET / 35492834706

91%

push

github

Fail fast when Alpha Vantage refuses a request for the account (#63)

Alpha Vantage answers a premium-only endpoint (TIME_SERIES_DAILY_ADJUSTED
on a free key) with HTTP 200 and an "Information" message instead of a
time series. The parser read that as invalid data and the retry policy
ran through the whole back-off budget before failing.

A premium-endpoint refusal or an invalid API key now throws the new
FinanceNetAccessDeniedException from every Alpha Vantage call. Like
FinanceNetNoDataException it derives from FinanceNetException, is not
retried and is not wrapped. The invalid-key check was previously only
in GetForexRecordsAsync and was retried. The rate-limit message stays
retryable.

466 of 631 branches covered (73.85%)

Branch coverage included in aggregate %.

21 of 25 new or added lines in 3 files covered. (84.0%)

1809 of 1869 relevant lines covered (96.79%)

93.61 hits per line