dapplo / Dapplo.Windows / 35456304188

44%

Build Type

push

github

Committed by Lakritzator

Commit Message

In KeyboardHookEventArgs and VirtualKeyCodeExtensions, IsModifier currently treats toggle/lock keys (Capital / CapsLock, NumLock, and Scroll / ScrollLock) as modifiers alongside chord modifier keys (Shift, Control, Alt/Menu, and Win).

Downstream consumers (such as Greenshot) filter out modifier keys when listening for hotkeys or starting chorded sequences (e.g. if (e.IsModifier) return;). Because ScrollLock evaluated IsModifier == true, standalone presses or sequence triggers starting with ScrollLock (e.g. ScrollLock + C) were inadvertently ignored.

Coverage Stats

615 of 2018 branches covered (30.48%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 2 files covered. (100.0%)

3 existing lines in 2 files now uncovered.

1714 of 5136 relevant lines covered (33.37%)

30.72 hits per line