facebookincubator / TTPForge / 35453502313

53%

main: 67%

Pull #643

github

Forward named environment variables to remote steps (#643)

Summary:

## Context

- Remote commands do not inherit the runner's environment. Callers need to explicitly forward selected values, such as run identifiers, to preserve execution context across SSH without editing each TTP.
- Preparing this change for public release also includes fixing the Go version mismatch exposed by GitHub CI. `go vet` failed on the existing `new("baz")` expression in `pkg/args/choices_test.go`, which requires Go 1.26, while the module selected Go 1.25.5. Updating Go and deriving the pre-commit version from `go.mod` are deliberate fixes for that public CI failure.

## This Diff

- Add repeatable `--forward-env NAME` and comma-separated `TTPFORGE_FORWARD_ENV` support for remote `inline:` and `file:` commands.
- Trim, merge, and deduplicate names from both sources. Require nonempty names to match `[A-Za-z_][A-Za-z0-9_]*`; fail the remote step before command dispatch on an invalid name, even if unset. Skip valid unset variables and preserve values that are set but empty.
- Preserve forwarded values literally, including `$forge.` references. Expand TTP-level and step-level `env` values and apply forwarded < TTP < step precedence.
- Document both forwarding forms, name validation, literal-value handling, and precedence in the remote execution guide and schema reference.
- Cover precedence, literal forwarding, and continued TTP/step expansion with 14 authenticated loopback SSH integration cases. Isolate helper tests from ambient forwarding settings.
- Add 24 invalid-name helper cases and 12 executor rejection cases covering both forwarding sources and POSIX, PowerShell, and cmd executor configurations. Verify no command reaches the backend on invalid input.
- Set the module minimum to Go 1.26.0 and select toolchain Go 1.26.5 to support the language features already used by the codebase.
- Have the GitHub pre-commit workflow read its Go version from `go.mod`, keeping public va... (continued)

36 of 37 new or added lines in 3 files covered. (97.3%)

3281 of 6235 relevant lines covered (52.62%)

15.22 hits per line