zostera / django-bootstrap3 / 35421671394

79%

push

github

Warn about settings in BOOTSTRAP3 that the package does not use (#1147)

An unknown key in settings.BOOTSTRAP3 was accepted and ignored, so a setting
removed in an earlier major release went on looking effective while doing
nothing.

Adds bootstrap3.apps with a system check registered against
django.core.checks. It compares the keys of settings.BOOTSTRAP3 against
BOOTSTRAP3_DEFAULTS and reports each key that is not there as bootstrap3.W001,
so it surfaces in manage.py check, runserver and CI, and can be silenced with
SILENCED_SYSTEM_CHECKS. REMOVED_SETTINGS gives a specific hint for base_url,
set_required and set_disabled, all removed in 11.0.0. A Warning rather than an
Error, since an extra key is not fatal.

The AppConfig is found automatically since Django 3.2, so existing users need
no change to INSTALLED_APPS.

BOOTSTRAP3_DEFAULTS holds every name the package passes to
get_bootstrap_setting, so it works as the whitelist unchanged. Checked by
extracting the call sites rather than assuming it, because the same premise
did not hold in django-bootstrap5.

Closes #1144

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

166 of 254 branches covered (65.35%)

Branch coverage included in aggregate %.

16 of 16 new or added lines in 1 file covered. (100.0%)

626 of 752 relevant lines covered (83.24%)

11.65 hits per line