zostera / django-bootstrap4 / 35421637783

87%

push

github

Warn about settings in BOOTSTRAP4 that the package does not use (#886)

An unknown key in settings.BOOTSTRAP4 was accepted and ignored, so a setting
dropped in an earlier release went on looking effective while doing nothing.

Adds bootstrap4.apps with a system check registered against
django.core.checks. It compares the keys of settings.BOOTSTRAP4 against
BOOTSTRAP4_DEFAULTS and reports each key that is not there as bootstrap4.W001,
so it surfaces in manage.py check, runserver and CI, and can be silenced with
SILENCED_SYSTEM_CHECKS. REMOVED_SETTINGS gives a specific hint for base_url,
dropped in 0.0.8. A Warning rather than an Error, since an extra key is not
fatal.

The AppConfig is found automatically since Django 3.2, so existing users need
no change to INSTALLED_APPS.

BOOTSTRAP4_DEFAULTS holds every name the package passes to
get_bootstrap_setting, so it works as the whitelist unchanged. Checked by
extracting the call sites rather than assuming it, because the same premise
did not hold in django-bootstrap5.

use_i18n is out of reach of this check, as the issue notes: it is a real key,
so it is accepted, but get_bootstrap_setting overwrites it with Django's
USE_I18N on every read. Documented in settings.rst and pinned by a test.

Closes #883

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

220 of 284 branches covered (77.46%)

Branch coverage included in aggregate %.

16 of 16 new or added lines in 1 file covered. (100.0%)

719 of 803 relevant lines covered (89.54%)

12.54 hits per line