openconfig / kne / 35395572327

44%

main: 44%

Build Type

Pull #768

github

Committed by kraney

Commit Message

exec/run, deploy: tag command output with the component that ran it

Deploying the components concurrently interleaves their kubectl output.
Every line is prefixed only with the binary that produced it, so a real
deployment emits runs like three "(kubectl): ..." lines sharing a
timestamp with nothing to say which component each belongs to. That
undoes much of the debuggability the per-component error attribution
was meant to provide.

Let a context carry a label, and prefix the output of commands run with
it as "(kubectl/SRLinux controller): ...". A context is the right
carrier here: the components already receive one, and a component does
not know its own name, since the name is derived by the deployment that
drives it.

The label is logging only. It deliberately does not tie a command's
lifetime to the context, as nothing today cancels a running kubectl;
that remains the gap defaultDeployTimeout covers from the outside.

LogCommand and the other existing helpers are unchanged, so callers that
do not run commands concurrently, notably cluster bringup, need not care.

Pull Request Pull Request #768: Pipeline KNE cluster init deploys

Coverage Stats

149 of 168 new or added lines in 5 files covered. (88.69%)

1 existing line in 1 file now uncovered.

5983 of 13447 relevant lines covered (44.49%)

0.51 hits per line