Qiskit / qiskit-addon-sqd-hpc / 35385231671

75%

push

github

Remove unused includes from the public headers (#62)

Several headers included standard library headers whose facilities they
never name.  Drop them:

  configuration_recovery.hpp  <optional> <random> <sstream>
  fermion.hpp                 <array> <climits> <functional>
  postselection.hpp           <cassert> <stdexcept>
  subsampling.hpp             <cmath> <cstddef> <random> <stdexcept>

Two cases deserve comment.  Neither configuration_recovery.hpp nor
subsampling.hpp needs <random>, despite both being templated on an RNG
type: they only pass the generator through to internal::NoReplacementSampler
and never name a std:: random facility themselves.  Under C++20,
internal/concepts.hpp includes <random> anyway for the
std::uniform_random_bit_generator concept.  Likewise, neither
postselection.hpp nor subsampling.hpp needs <stdexcept>, as both throw
exclusively through QKA_SQD_THROW_INVALID_ARGUMENT_, and
internal/exception-macros.hpp owns that include.

<iostream> is deliberately retained in configuration_recovery.hpp.  It is
used only under `#if QKA_SQD_DEBUG_RECOVERY`, which nothing in the tree
defines, but that path should keep compiling when it is switched on, and
relying on exception-macros.hpp to supply <iostream> transitively would be
fragile.  <cstdlib> is likewise retained for integer std::abs.

Separately, spell the default template argument of MatchesRightLeftHamming
as std::uint32_t rather than bare uint32_t.  <cstdint> is only guaranteed
to declare the std::-qualified names; the unqualified spelling happens to
work on libstdc++ but is not portable.  This was the only unqualified
<cstdint> type name under include/, test/, and benchmark/.

Verified against all three build configurations (C++17, C++20, and
-fno-exceptions/-fno-rtti) with tests passing, and each header also
compiles standalone under both standards.

Assisted-by: Claude Opus 5

770 of 1134 branches covered (67.9%)

Branch coverage included in aggregate %.

683 of 802 relevant lines covered (85.16%)

304565.66 hits per line