umputun / agterm / 35376351302
93%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 146
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 93.024%. Remained the same
35376351302

push

github

web-flow 
share one cancellable output capture between the zmx and ssh runners (#627)

* share one cancellable output capture between the zmx and ssh runners

a write end inherited by a long-lived surface child no longer leaves two reader threads, their fds and their buffers stuck for that child's lifetime. Both runners drain through ProcessOutputCapture, and a missed output deadline cancels both of its DispatchIO read channels.

RemoteCommandProcessRunner also gets FD_CLOEXEC on its pipes and the bounded post-exit join ZmxClient already had. A miss returns -1 with empty stdout, so partial output cannot replace the diagnostic.

* test that collect timeouts and cancellation close both read ends

the tests hold duplicates of the capture's write ends, standing in for an inheriting child, and expect EPIPE on both once collect misses or cancel runs. Without the cancel calls both tests fail.

* keep trampoline test output until the parent acknowledges it

on macOS, exit-time pty cleanup can discard unread output if the reader stalls. This reproduces the empty result seen in environmentIsReplacedAndPreservesNewlines on CI. The tests that check output now spawn session-host-pty-probe, a C fixture that reports its env, arguments, cwd, window size or an fd, then waits for the parent's acknowledgement before exiting. The regression test waits 1.5 s before reading and fails when the probe exits without waiting.

11495 of 12357 relevant lines covered (93.02%)

3302329.81 hits per line

Jobs
ID Job ID Ran Files Coverage
1 35376351302.1 146
93.02
 GitHub Action Run
Source Files on build 35376351302