stacklok / toolhive / 35348128281

71%

Build Type

push

github

Committed by web-flow

Commit Message

fix(operator): forward default Redis password to MCPServer and MCPRemoteProxy (#6679)

VirtualMCPServer already fell back to TOOLHIVE_DEFAULT_REDIS_SECRET_NAME/KEY
when spec.sessionStorage is unset, but MCPServer and MCPRemoteProxy only
injected THV_SESSION_REDIS_PASSWORD when an explicit passwordRef was set.
Both still picked up the default Redis address, so pods deployed against an
authenticated global default Redis/Valkey instance connected without a
password and crash-looped with "NOAUTH Authentication required".

Mirror VirtualMCPServer's buildRedisPasswordEnvVar fallback in
MCPServerReconciler.buildRedisPasswordEnvVar and
buildRedisPasswordEnvVarForRemoteProxy so the default address and default
password always travel together, while an explicit spec.sessionStorage
remains authoritative and never falls through to the global default.

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

Coverage Stats

38 of 38 new or added lines in 2 files covered. (100.0%)

10 existing lines in 3 files now uncovered.

82426 of 116404 relevant lines covered (70.81%)

107.27 hits per line