• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

LFDT-Panurus / panurus / 35330177305
85%

Build:
DEFAULT BRANCH: main
Ran 18 Sep 2026 09:44AM UTC
Jobs 69
Files 560
Run time 5min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

18 Sep 2026 09:33AM UTC coverage: 83.551% (+0.03%) from 83.52%
35330177305

push

github

AkramBitar
fix(storage): repair keyset pagination and guard the query DSL's landmines

Closes out the medium/low findings from the review of the SQL query-builder DSL
under token/services/storage/db/sql/query. Almost all of them are landmines
rather than live bugs: public entry points that panic or emit invalid SQL, which
no caller reaches today, so a future caller would be the one to find out.

Correctness:

- pagination.KeysetWithId shipped dead and panicking. It returned
  *keyset[I, V] for the caller's row type V, but interpreter.PreProcess and
  NewPage only type-switch on the any-erased instantiation, and generic
  instantiations are distinct concrete types, so every call fell through to
  panic in both places. The internal type collapses to keyset[I] with an
  idGetter func(any) I, so all four constructors produce the one type the
  dispatch matches.
- cond.InTuple had no empty-list guard. Both dialect interpreters
  short-circuit to writing nothing for an empty list, and And/Or can only
  filter out the AlwaysTrue/AlwaysFalse sentinels, so a condition that
  rendered to the empty string stayed in the list and emitted a leading
  operator with no left operand, e.g. "( AND status = $1)". It now returns
  AlwaysTrue on an empty field or value list, matching In/FieldIn.
- The keyset "no cursor" sentinel could collide with real data: the marker was
  the in-band value -1 (int) / "" (string), so a page whose last row
  legitimately carried one of those ids fell back to OFFSET, reintroducing the
  skip/duplicate-under-concurrent-write window keyset pagination exists to
  close. FirstID/LastID are now *I and nilElement is gone.
- WriteInTuple checked the tuples in vals only against each other and never
  against the field list they are compared with, so one field against an empty
  tuple panicked on vals[0][0]; several empty tuples rendered
  "(id) IN (($1), ($2))" while binding no parameter and desynchronising every
  later placeholder; a tuple wider than a sin... (continued)

93 of 99 new or added lines in 10 files covered. (93.94%)

15 existing lines in 4 files now uncovered.

40860 of 48904 relevant lines covered (83.55%)

27449.83 hits per line

Uncovered Changes

Lines Coverage ∆ File
2
10.26
0.0% token/services/storage/db/sql/query/pagination/offset.go
2
63.64
0.0% token/services/storage/db/sql/query/pagination/page.go
1
94.44
0.0% token/services/storage/db/sql/query/pagination/interpreter.go
1
94.38
17.37% token/services/storage/db/sql/query/pagination/keyset.go

Coverage Regressions

Lines Coverage ∆ File
9
86.26
-4.95% token/services/selector/sherdlock/selector.go
2
88.47
-0.36% token/services/benchmark/runner.go
2
91.59
-0.37% token/services/identity/membership/lm.go
2
74.55
-0.73% token/services/storage/ttxdb/store.go
Jobs
ID Job ID Ran Files Coverage
1 itest-update-t2 - 35330177305.1 18 Sep 2026 09:50AM UTC 499
37.89
GitHub Action Run
2 itest-interop-dlog-t3 - 35330177305.2 21 Sep 2026 01:16PM UTC 499
41.02
GitHub Action Run
3 itest-fabtoken-fabric-t5 - 35330177305.3 18 Sep 2026 09:47AM UTC 499
30.99
GitHub Action Run
4 itest-fabtoken-fabric-t3 - 35330177305.4 18 Sep 2026 09:46AM UTC 499
29.43
GitHub Action Run
5 itest-dlog-fabric-t9 - 35330177305.5 18 Sep 2026 09:47AM UTC 499
34.79
GitHub Action Run
6 itest-dlogstress-t1 - 35330177305.6 18 Sep 2026 09:44AM UTC 499
37.68
GitHub Action Run
7 itest-fabtoken-fabric-t2 - 35330177305.7 18 Sep 2026 09:48AM UTC 499
27.61
GitHub Action Run
8 itest-dlog-fabric-t11 - 35330177305.8 18 Sep 2026 09:50AM UTC 499
32.82
GitHub Action Run
9 itest-dlog-fabric-t7 - 35330177305.9 18 Sep 2026 09:48AM UTC 499
33.97
GitHub Action Run
10 itest-interop-dlog-t5 - 35330177305.10 18 Sep 2026 09:49AM UTC 499
40.53
GitHub Action Run
11 itest-dvp-dlog - 35330177305.11 18 Sep 2026 09:46AM UTC 507
38.41
GitHub Action Run
12 itest-dvp-fabtoken - 35330177305.12 18 Sep 2026 09:46AM UTC 507
30.77
GitHub Action Run
13 itest-nft-fabtoken - 35330177305.13 18 Sep 2026 09:45AM UTC 507
29.3
GitHub Action Run
14 itest-dlog-fabric-t2 - 35330177305.14 18 Sep 2026 09:49AM UTC 499
33.59
GitHub Action Run
15 itest-update-t1 - 35330177305.15 18 Sep 2026 09:51AM UTC 499
42.93
GitHub Action Run
16 itest-interop-fabtoken-t5 - 35330177305.16 18 Sep 2026 09:47AM UTC 499
32.6
GitHub Action Run
17 itest-fabtoken-fabric-t4 - 35330177305.17 18 Sep 2026 09:48AM UTC 499
31.16
GitHub Action Run
18 itest-dlog-fabric-t2.1 - 35330177305.18 18 Sep 2026 09:49AM UTC 499
33.53
GitHub Action Run
19 itest-update-t4 - 35330177305.19 18 Sep 2026 09:48AM UTC 499
42.62
GitHub Action Run
20 itest-fabricx-dlog-t16-websocket - 35330177305.20 18 Sep 2026 09:57AM UTC 519
42.59
GitHub Action Run
21 itest-fabricx-dlog-t11 - 35330177305.21 18 Sep 2026 09:50AM UTC 519
33.01
GitHub Action Run
22 itest-dloghsm-fabric-t1-libp2p - 35330177305.22 18 Sep 2026 09:53AM UTC 500
42.88
GitHub Action Run
23 itest-dlog-fabric-t8-websocket - 35330177305.23 18 Sep 2026 09:50AM UTC 499
42.94
GitHub Action Run
24 itest-fabricx-dlog-t4 - 35330177305.24 18 Sep 2026 09:50AM UTC 519
39.05
GitHub Action Run
25 itest-interop-fabtoken-t4 - 35330177305.25 18 Sep 2026 09:46AM UTC 499
31.75
GitHub Action Run
26 itest-dlog-fabric-t13 - 35330177305.26 18 Sep 2026 09:48AM UTC 499
36.87
GitHub Action Run
27 itest-dlog-fabric-t12 - 35330177305.27 18 Sep 2026 09:48AM UTC 499
40.1
GitHub Action Run
28 itest-nft-dlog - 35330177305.28 18 Sep 2026 09:46AM UTC 507
36.99
GitHub Action Run
29 itest-fabricx-dlog-t1-websocket - 35330177305.29 18 Sep 2026 09:54AM UTC 519
42.41
GitHub Action Run
30 utest-unit-tests-regression - 35330177305.30 18 Sep 2026 09:48AM UTC 559
74.92
GitHub Action Run
31 itest-interop-dlog-t1 - 35330177305.31 18 Sep 2026 09:51AM UTC 499
42.05
GitHub Action Run
32 itest-dloghsm-fabric-t2-replicas - 35330177305.32 18 Sep 2026 09:54AM UTC 500
44.8
GitHub Action Run
33 itest-fabtoken-fabric-t1-replicas - 35330177305.33 18 Sep 2026 09:53AM UTC 499
36.62
GitHub Action Run
34 itest-dlog-fabric-t3 - 35330177305.34 18 Sep 2026 09:47AM UTC 499
37.09
GitHub Action Run
35 itest-dlog-fabric-t1-replicas - 35330177305.35 18 Sep 2026 09:54AM UTC 499
44.58
GitHub Action Run
36 itest-dlog-fabric-t6-replicas - 35330177305.36 18 Sep 2026 09:54AM UTC 499
44.74
GitHub Action Run
37 itest-dlog-fabric-t5 - 35330177305.37 18 Sep 2026 09:46AM UTC 499
38.94
GitHub Action Run
38 itest-interop-fabtoken-t1 - 35330177305.38 18 Sep 2026 09:51AM UTC 499
34.13
GitHub Action Run
39 itest-dlog-fabric-t6-websocket - 35330177305.39 18 Sep 2026 09:52AM UTC 499
43.04
GitHub Action Run
40 itest-interop-dlog-t4 - 35330177305.40 18 Sep 2026 09:49AM UTC 499
39.6
GitHub Action Run
41 itest-dlog-fabric-t1-libp2p - 35330177305.41 18 Sep 2026 09:52AM UTC 499
42.83
GitHub Action Run
42 itest-fabricx-dlog-t6-libp2p - 35330177305.42 18 Sep 2026 09:56AM UTC 519
42.59
GitHub Action Run
43 itest-dlog-fabric-t4 - 35330177305.43 18 Sep 2026 09:47AM UTC 499
38.88
GitHub Action Run
44 utest-unit-tests-race - 35330177305.44 18 Sep 2026 09:48AM UTC 559
74.92
GitHub Action Run
45 itest-fabricx-dlog-t3 - 35330177305.45 18 Sep 2026 09:50AM UTC 519
36.97
GitHub Action Run
46 itest-fabtoken-dlog-fabric - 35330177305.46 18 Sep 2026 09:55AM UTC 499
42.07
GitHub Action Run
47 itest-dlog-fabric-t10-replicas - 35330177305.47 18 Sep 2026 09:55AM UTC 499
45.51
GitHub Action Run
48 itest-fabricx-dlog-t13 - 35330177305.48 18 Sep 2026 09:49AM UTC 519
36.74
GitHub Action Run
49 itest-fabricx-dlog-t5 - 35330177305.49 18 Sep 2026 09:48AM UTC 519
39.04
GitHub Action Run
50 itest-fabtoken-fabric-t1-libp2p - 35330177305.50 18 Sep 2026 09:52AM UTC 499
34.93
GitHub Action Run
51 itest-fabricx-dlog-t6-replicas - 35330177305.51 18 Sep 2026 09:57AM UTC 519
44.18
GitHub Action Run
52 itest-dloghsm-fabric-t2-websocket - 35330177305.52 18 Sep 2026 09:53AM UTC 500
43.09
GitHub Action Run
53 itest-dloghsm-fabric-t2-libp2p - 35330177305.53 18 Sep 2026 09:53AM UTC 500
43.08
GitHub Action Run
54 itest-dloghsm-fabric-t1-replicas - 35330177305.54 18 Sep 2026 09:54AM UTC 500
44.63
GitHub Action Run
55 itest-interop-fabtoken-t3 - 35330177305.55 18 Sep 2026 09:50AM UTC 499
33.18
GitHub Action Run
56 itest-dlog-fabric-t10-libp2p - 35330177305.56 18 Sep 2026 09:52AM UTC 499
43.78
GitHub Action Run
57 itest-dloghsm-fabric-t1-websocket - 35330177305.57 18 Sep 2026 09:52AM UTC 500
42.9
GitHub Action Run
58 itest-fabtoken-fabric-t1-websocket - 35330177305.58 18 Sep 2026 09:52AM UTC 499
34.95
GitHub Action Run
59 itest-fabricx-dlog-t1-replicas - 35330177305.59 18 Sep 2026 09:58AM UTC 519
44.02
GitHub Action Run
60 itest-dlog-fabric-t10-websocket - 35330177305.60 18 Sep 2026 09:53AM UTC 499
43.81
GitHub Action Run
61 itest-fabricx-dlog-t1-libp2p - 35330177305.61 18 Sep 2026 09:56AM UTC 519
42.4
GitHub Action Run
62 itest-update-t3 - 35330177305.62 18 Sep 2026 09:53AM UTC 499
38.37
GitHub Action Run
63 itest-fabricx-dlog-t16-libp2p - 35330177305.63 18 Sep 2026 09:57AM UTC 519
42.59
GitHub Action Run
64 itest-dlog-fabric-t6-libp2p - 35330177305.64 18 Sep 2026 09:51AM UTC 499
43.04
GitHub Action Run
65 itest-fabricx-dlog-t6-websocket - 35330177305.65 18 Sep 2026 09:56AM UTC 519
42.58
GitHub Action Run
66 itest-fabricx-dlog-t16-replicas - 35330177305.66 18 Sep 2026 09:57AM UTC 519
44.2
GitHub Action Run
67 itest-dlog-fabric-t8-libp2p - 35330177305.67 18 Sep 2026 09:52AM UTC 499
42.9
GitHub Action Run
68 itest-dlog-fabric-t1-websocket - 35330177305.68 18 Sep 2026 09:52AM UTC 499
42.87
GitHub Action Run
69 itest-dlog-fabric-t8-replicas - 35330177305.69 18 Sep 2026 09:52AM UTC 499
44.64
GitHub Action Run
Source Files on build 35330177305
  • Tree
  • List 560
  • Changed 64
  • Source Changed 10
  • Coverage Changed 63
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #35330177305
  • 35fdc251 on github
  • Prev Build on main (#35308968538)
  • Next Build on main (#35418866690)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc