zalando / logbook / 5917

97%

master: 100%

push

github

fix: Use status based log level when ECS format and status code based log writing is enabled (#2379)

* Added new StatusCodeBasedEcsSink by extending EcsSink to allow more flexible Logger level selection based on HTTP response status

* Updated autoconfiguration to support EcsSink and StatusCodeBasedEcsSink creation. Updated autoconfiguration tests

* Added unit testes for EcsSink and StatusCodeBasedEcsSink

* Make test method name more explicit

* Fixed logger assertions in unit tests by injecting the logger when constructing ECS sinks so logging level behavior can be asserted properly

* Moved logging level decision logic based on HTTP code into an abstract class for subclasses to re-use. Created separate interface for ECS related sinks to re-use request/response writing logic across various implementations. Moved creation of HttpStatusCodeBasedSink into a separate conditional autoconfiguration method.

* Updated documentation on HTTP code based logging level feature and ECS formatting

* Moved AbstractHttpStatusCodeSink into logbook-core. Brought back old classes to avoid breaking changes and marked them as deprecated. Added tests for scenarios where user defined bean exists and when chunking sink is enabled. Added back @ConditionalOnMissingBean to backoff bean creation when user defined beans exist.

* Added tests for no-args constructor in AbstractHttpStatusCodeBasedSink and HttpStatusCodeBasedSink

* Implemented changes based on PR #2388 - activate DefaultEcsSink only when TRACE level is enabled

* Updated javadoc description regarding deprecated LevelBasedHttpLogWriter replacement

896 of 946 branches covered (94.71%)

23 of 23 new or added lines in 3 files covered. (100.0%)

4103 of 4250 relevant lines covered (96.54%)

0.97 hits per line