Logflare / logflare / 35275389197-1

83%

Build Type

push

github

Committed by web-flow

Commit Message

fix: make "Load more" page reliably through search events (#3986)

Squashes the nine-PR load more stack into one commit: #3976, #3977, #3978,
#3979, #3980, #3981, #3982, #3984 and #3986. Merged as a unit so that main
never carries the intermediate states that #3984 corrects.

Pagination

- Keep the "Load more" spinner up until the page query returns.
- Bound a page request to the window in view and say so on the button.
- Store one page window per search in `EventPagination`. The label, the
  query, the cursor shift and the range growth all read it. The window no
  longer doubles on each click.
- Set the page window from a tail result too. A soft pause, play and pause
  used to leave the window nil and drop the next page request.
- Write an implied timestamp range into the query on a page request.
- Keep a one-sided `t:` bound when a page request makes the range explicit.
- Clamp a "next" range extension at now. Each empty click used to push the
  range max another window into the future.
- Cap the cursor of an empty "next" page at the request time.
- Remove timestamp clauses that can never match.
- Stop hiding the load more buttons on a short page.
- Disable the other button while a page request runs.
- Drop a page result or page error that no request waits for.
- Clear the page spinner when a search fails to parse.
- Log a page request that the LiveView drops.

Scrolling

- The LiveView drives every scroll. Every initial event page and every tail
  append pushes `scroll-to-bottom`. The server owns scroll intent. The hook
  owns viewport stability.

Cleanup

- Remove the unused sentinel row: the extra fetched row, `fetch_limit/0`
  and the `has_more?` field that nothing reads.
- Build the chart range in the search timezone. An implied range is no
  longer UTC written as local time.
- Remove the 750ms LiveView latency simulator in dev.

Tests

- Cover event pagination against a bigquery source and a postgres source.

Co-Authored-By: Claude Opus 5 (1M ... (continued)

Coverage Stats

111 of 130 new or added lines in 8 files covered. (85.38%)

7 existing lines in 6 files now uncovered.

15557 of 18680 relevant lines covered (83.28%)

1694.08 hits per line