microlinkhq / metascraper / 35268512252

95%

push

github

fix: use @kikobeats/got to support Node.js 24.20 (#881)

* fix: use @kikobeats/got to support Node.js 24.20

got@11 is unmaintained and breaks on Node.js 24.20 (nodejs/node#64847):
a retried connection error rejects with ERR_SOCKET_CLOSED_BEFORE_CONNECTION
and then crashes the process with uncaught exceptions. @kikobeats/got is
got@11 with that fix backported.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VZiY7VMgg1nEMkCezwMXEC

* ci: allow builds for every pnpm command

pnpm test/run re-installs when workspace settings changed after install
(e.g. minimumReleaseAgeExclude written for a fresh dependency). That
implicit install did not get --dangerously-allow-all-builds and failed
with ERR_PNPM_IGNORED_BUILDS. Setting it as env covers all pnpm calls.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix: restore CI on Node 24.20

Ignore msapplication-TileColor as a logo, alias got to
@kikobeats/got so DNS retries don't crash, and pass
GITHUB_TOKEN so youtube-dl-exec is not rate-limited.

Co-authored-by: Cursor <cursoragent@cursor.com>

* test: stop depending on teslahunt.io

The domain no longer resolves, which hung favicon cache tests
and wiped X profile descriptions when a t.co hop failed.

Co-authored-by: Cursor <cursoragent@cursor.com>

* ci: pass GITHUB_TOKEN only to pnpm install

youtube-dl-exec needs it to fetch yt-dlp; tests and Coveralls do not.

Co-authored-by: Cursor <cursoragent@cursor.com>

* test: stop snapshotting live favicon URLs

Logo reachability changes with the remote host, which made
integration snapshots fail under fail-fast.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix: catch sync resolveUrl throws in metascraper-x

Promise.resolve(resolveUrl(url)) throws before .catch can run, so keep the original URL. Also strip only a trailing slash in the test helper so redirect paths stay intact.

Co-authored-by: Cursor <cursoragent@cursor.... (continued)

360 of 400 branches covered (90.0%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

1311 of 1441 relevant lines covered (90.98%)

13.96 hits per line