eclipse-aascw / aas-core-codegen / 35266621951

90%

push

github

State the type instead of contracting it (#711)

A contract which only checks a type says at run time what the signature
can say at import time, and says it to nobody: ``mypy`` does not read
it, so a caller passing the wrong thing is found by a test, if at all,
rather than by the type checker.

``intermediate`` gains the union the Java generators kept spelling out:

    ContainerTypeAnnotation = Union[ListTypeAnnotation, TupleTypeAnnotation]

It is the complement of ``AtomicTypeAnnotation`` beneath an optional,
and it carries the same invariants the neighbouring aliases do -- an
``AsTuple`` twin checked against ``get_args``, and
``assert_union_without_excluded`` against ``TypeAnnotationUnion``.

The contracts which remain are the ones a type can not express: ``not
_is_instance_type(type_anno)`` is a predicate on the ``our_type``
*inside* an ``OurTypeAnnotation``, and the rest are arity bounds, naming
rules and "not implementation-specific".

32 of 32 new or added lines in 3 files covered. (100.0%)

34327 of 40078 relevant lines covered (85.65%)

2.57 hits per line