Logflare / logflare / 35265459042-1

83%

main: 84%

Build Type

Pull #3976

github

Committed by chasers

Commit Message

fix: keep the "Load more" spinner up until the page query returns

The button drove its spinner from `phx-click-loading`, which LiveView applies
only while the event round trip is in flight. `load_events` hands the query to
`SearchQueryExecutor` and returns immediately, so the spinner stopped in
milliseconds while a BigQuery page query still took seconds.

`EventPagination` now carries a `loading_intent` and a fourth button state,
`:loading`. `load_events` marks the intent, and the page result and page error
handlers clear it. The button renders its spinner from that state. A hidden
button stays hidden, and `disabled={@state != :ready}` already covers
`:loading`, so a second click cannot queue behind the first.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YBPF1knvgfghTSdxuYryGL

Pull Request Pull Request #3976: fix: keep the "Load more" spinner up until the page query returns

Coverage Stats

13 of 14 new or added lines in 3 files covered. (92.86%)

3 existing lines in 3 files now uncovered.

15534 of 18664 relevant lines covered (83.23%)

2172.55 hits per line