eclipse-aascw / aas-core-codegen / 35255278886

90%

push

github

Index the Java XML writers by kind (#708)

A writer used to be generated per type, which produced whole families of
functions that differed in nothing but a declared type. Four of them
wrote a list item:

    private static void writeAtV_bool(
      Boolean that,
      XMLStreamWriter writer) {
      writeElement(
        "v", that, writer, _VisitorWithWriter::writeStringifiedContent);
    }

    private static void writeAtV_long(
      Long that,
      XMLStreamWriter writer) {
      writeElement(
        "v", that, writer, _VisitorWithWriter::writeStringifiedContent);
    }

    // ... and the same again for Double and for String

Eighteen of them wrote a list in the AAS meta-model:

    private static void writeListOf_IExtension(
      List<IExtension> that, XMLStreamWriter writer) {
      int index = 0;
      try {
        for (IExtension item : that) {
          writeClass(item, writer);
          index++;
        }
      } catch (_SerializeFailure failure) { /* prepend the index */ }
    }

    private static void writeListOf_IQualifier(
      List<IQualifier> that, XMLStreamWriter writer) {
      int index = 0;
      try {
        for (IQualifier item : that) {
          writeClass(item, writer);
          index++;
        }
      } catch (_SerializeFailure failure) { /* prepend the index */ }
    }

    // ... and sixteen more, all of them this

Nothing in either family depends on the type it names. Once a value is
at hand, what is written follows from what it *is*: a scalar is rendered
through ``toString``, a byte array through base64, a literal through the
text it carries, and an instance through the element its run-time type
names. There are five such kinds -- ``stringified``, ``bytes``,
``IEnum``, ``IClass``, ``IUnion`` -- and the shared content writers
already said so, with one ``writeStringifiedContent`` for all four
scalars and one ``writeEnum`` for every enumeration. Only the list, the
tuple and the positional item writers were left ou... (continued)

88 of 88 new or added lines in 2 files covered. (100.0%)

34257 of 39999 relevant lines covered (85.64%)

2.57 hits per line