Mellanox / network-operator / 35212934362
64%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 63
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 62.882% (+0.2%) from 62.658%
35212934362

push

github

web-flow 
feat: align DOCA Telemetry Service deployment with the DPF chart (#3219)

The DaemonSet kept no state on the node and gave local clients no way to
consume telemetry over IPC, so it could not stand in for the DTS
deployment that DPF ships.
Give it the host paths it was missing: configuration and data now
persist under /var/opt/doca-telemetry rather than inside the container,
and logs land in /var/log/doca/telemetry. That prefix follows the OFED
driver DaemonSet, which already keeps writable node-local state under
/var/opt, instead of the /opt/mellanox/doca/services default documented
for DTS.
Serving IPC needs both halves of its transport. Short messages go over
UNIX domain sockets, which are filesystem objects that a shared IPC
namespace does not expose, hence the ipc_sockets host path; payloads go
through shared memory, hence hostIPC and the /dev/shm mount. How wide
that mount should be is a user-facing choice, so it comes from a new
shareHostSharedMemory field on DOCATelemetryServiceSpec: clients running
directly on the node need the host's whole /dev/shm, while containerized
ones only need /dev/shm/telemetry. It defaults to false, which narrows
what DTS is given today, so node-local clients now have to opt in.
Persisting /config also changes what the container command has to do.
Clearing it on every start would discard the node's configuration, and
telemetry-init.sh only generates configuration into an empty /config, so
FORCE_CONFIG_OVERWRITE is what keeps the ConfigMap authoritative. Drop
PROMETHEUS_XCSET_JOIN_FIELDS and PROMETHEUS_XCSET_MANDATORY_TYPES while
here, since they override behavior that belongs to the DTS
configuration.

5067 of 8058 relevant lines covered (62.88%)

53.62 hits per line

Coverage Regressions

Lines Coverage ∆ File
5
77.38
-5.95% controllers/ipoibnetwork_controller.go
4
74.63
-1.49% controllers/drain_controller.go
2
88.46
-2.56% controllers/macvlannetwork_controller.go
2
73.43
-0.31% pkg/state/state_ofed.go
2
85.57
-0.52% pkg/state/state_skel.go
1
84.19
2.14% controllers/nicclusterpolicy_controller.go
Jobs
ID Job ID Ran Files Coverage
1 35212934362.1 63
62.88
GitHub Action Run
Source Files on build 35212934362