msiemens / tinydb / 35117635804

97%

push

github

fix: fix LRUCache treating stored None values as missing (#635)

get() and __getitem__ used to check `value is not None` to decide
whether a key was present, so an entry deliberately set to None looked
identical to a cache miss: __getitem__ raised KeyError for it, get()
returned the default instead of None, and it never got its LRU
position refreshed on read.

Now both methods look the key up against the OrderedDict with a
private sentinel default, so presence is checked directly rather than
inferred from the value.

161 of 174 branches covered (92.53%)

Branch coverage included in aggregate %.

9 of 9 new or added lines in 1 file covered. (100.0%)

639 of 643 relevant lines covered (99.38%)

11.52 hits per line