tari-project / tari / 35102703514

74%

Build Type

push

github

Committed by web-flow

Commit Message

test: stop comms tests dialling links something else already dials (#8008)

Both tests dial a peer that is already being dialled, and the redundant
connection is tie-broken against the live one. The dialer de-duplicates
only dials that are still in flight, and `handle_dial_peer` decides from
the connectivity pool, so a dial issued after the first has completed
but before `PeerConnected` reached the connectivity actor is issued
again.

Outbound messaging does requeue a failed write, but `MAX_SEND_RETRIES`
is 1: after two failed `try_establish` attempts `run_inner` calls
`fail_all_pending_messages`, which does not requeue. The messages are
gone and the test waits for one that will never arrive.

test_dht_propagate_dedup dialled each link itself, on top of every
node's DHT connectivity already dialling its seeded peers at start-up -
that goes via ProactiveDialer, which bypasses handle_dial_peer and does
not even log. Every link was dialled twice from the same side, which is
why the tie-breaks were all (Existing = Outbound, New = Outbound). Node
A is now seeded with both B and C, and ensure_connected dials only a
link that has not come up within DIAL_FALLBACK_GRACE. The fallback is
not optional: the DHT tries once at start-up and then not again until
update_interval (2 minutes), so one attempt lost under load hangs the
test. That failure mode only appeared under --release, after 450 clean
debug runs.

peer_to_peer_messaging_simultaneous let node 2 dial back because its
pool had not registered the inbound connection yet. Both pools are now
confirmed before either node sends.

Each node is waited on only for the peers it has to send to, which is
the pool lookup propagation actually performs - a receiver does not need
the connection in its own pool to be delivered to, and requiring that
only added a way for the barrier to time out on something unused.

Measured under 3x CPU oversubscription, the dedup test goes from 8-10
dials and 1-3 tie-breaks per run to z... (continued)

Coverage Stats

2 of 2 new or added lines in 1 file covered. (100.0%)

30 existing lines in 9 files now uncovered.

86491 of 137540 relevant lines covered (62.88%)

193159.97 hits per line