wirenboard / wb-cloud-agent / 21

98%

main: 98%

Build Type

Pull #81

github

Committed by smintank

Commit Message

Drop recovery code paths that cannot run on a controller

Provider configs live on ext4 under a root-owned /etc or /mnt/data, so the
rename fallback for filesystems without hardlinks, the fchown of the staged
file and the create_parent switch on write_to_file had no caller or trigger.
Copies named after the failure time were never written by a released version,
so drop_stale_files only sweeps interrupted temp files now.

The "not a regular file" rule moves into recover_provider_config, which lets
both callers treat every ConfigError the same way and removes ConfigReadError.
The staging sequence resolves the symlink once and reports any OSError through
a single ConfigError.

Comments shrink to the facts outside the code's control: the ATECC bus on
WB6, systemd status 6, the wb-configs symlink, pre-1.6.0 configs, the root
logger reset and the clock before NTP. Tests that repeated an existing case
or pinned a constant's own definition are removed.

Pull Request Pull Request #81: CLOUD-599 Restore damaged production provider configuration

Coverage Stats

521 of 543 new or added lines in 10 files covered. (95.95%)

10 existing lines in 3 files now uncovered.

2783 of 2852 relevant lines covered (97.58%)

1.95 hits per line