FlexMeasures / flexmeasures / 35093099521

86%

Build Type

push

github

Committed by web-flow

Commit Message

Hold an automation's schedule to the sensors it was checked against (#2536)

* Hold an automation's schedule to the sensors it was checked against

An automation's output sensors are checked against its creator's permissions when the automation is created,
which is the only moment a user is present.
They are predicted from the fields that name them, and a sensor the prediction misses is not left unchecked
so much as checked for the wrong thing: it is read as an input, so read access is asked for
where recording data calls for create-children access.

A schedule job created by an automation is now held to that prediction, and refuses to record on any other sensor.
Where there is nothing to hold the job to, it proceeds as before: a job that is not an automation's,
an automation deleted since the job was queued, or one whose sensors cannot be determined, which is logged.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WS6V8nZyRzMxsvqGnNpUTk
Signed-off-by: F.N. Claessen <claessen@seita.nl>

* changelog: point at the PR number

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WS6V8nZyRzMxsvqGnNpUTk
Signed-off-by: F.N. Claessen <claessen@seita.nl>

* Give the scheduler its flex config as written, and hold the guard to it

`resolve_schedule_automation_sensors` handed the scheduler a flex config that had already
been through `AssetTriggerSchema`, so `collect_flex_config` — which merges the asset tree's
config with the message's, reading sensors by id — met `Sensor` objects where it expects ids
and raised a `ProgrammingError` no caller catches.

A data generator deserializes its own config, so the scheduler now receives the config as it
was written and does that itself. The trigger message is loaded for its timing and its asset
only. A database error joins what is reported as unknown sensors, that being what it means
here.

With resolution reliable, th... (continued)

Coverage Stats

30 of 32 new or added lines in 2 files covered. (93.75%)

4 existing lines in 1 file now uncovered.

19077 of 22306 relevant lines covered (85.52%)

0.86 hits per line