safe-global / safe-client-gateway / 35091374257

89%

push

github

fix(transactions): drop the redirect on every message-by-hash lookup (#3398)

* fix(transactions): drop the redirect on every message-by-hash lookup

`getMessageByHash` builds `/api/v1/messages/{hash}` without a trailing
slash. Django's APPEND_SLASH answers that with a 301 to
`/api/v1/messages/{hash}/`, so every lookup costs two round trips.

Over 15 days of production spans, all 3,501 calls to the slashless path
returned 301 — across 25 chains, with no other status observed. The
followed request is where the real answer comes from (4,252 × 404,
1,402 × 200).

The neighbouring URLs in this file — safes/{address}/messages/ and
messages/{hash}/signatures/ — already end in a slash; this one was the
outlier. The cache key comes from `CacheRouter.getMessageByHashCacheDir`,
not the URL, so nothing is invalidated by the change.

* test(notifications): update message URL mocks for the trailing slash

The MESSAGE_CREATED push-notification flow fetches the message by hash, and
these mocks still matched the slashless URL, so the fetch missed and no
notification was enqueued.

4167 of 4899 branches covered (85.06%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

10582 of 11643 relevant lines covered (90.89%)

539.14 hits per line