mozilla-releng / balrog / #5750

90%

push

circleci

public: return 400 instead of a 500 when the JSON API serves a non-Guardian blob (#3899)

The JSON get_update endpoint assumed any blob matched by a rule has
getResponse(). DesupportBlob and other XML-only blobs don't, so serving
one via /json/* raised AttributeError and produced a 500 (and a Sentry
report) instead of a client error.

Mirror the XML endpoint's blob type check: raise BadDataError, which the
Flask error handler already turns into a 400.

2190 of 2578 branches covered (84.95%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

5777 of 6308 relevant lines covered (91.58%)

0.92 hits per line