TYPO3BestPractices / tea / 35087656922
100%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 6
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
35087656922

push

github

web-flow 
[TASK] Pin the tests to the installed TYPO3 version (#2327)

The unit and the functional tests ran against whatever TYPO3 version
happened to be installed. The option `-t` of `runTests.sh` only
selected the version to install the dependencies for and the PHPStan
configuration, so a test run made for one version against the
dependencies of the other failed somewhere in the middle of the
suite, where the cause is hard to recognize.

The new `Tests/Support/VersionCompatibilityTestsTrait.php` holds the
tests which verify the TYPO3 version, and both the unit and the new
functional `VersionCompatibilityTest` use it, so the two suites
cannot drift apart. It is annotated with `@phpstan-require-extends`,
so that it can only be used by a PHPUnit test case. Besides the
check that the installed version is a supported one, it holds one
test pinned to each of the supported versions by a
`not-core-<version>` group.
`runTests.sh` excludes the groups which do not belong to the version
given with `-t`, so exactly the test of the selected version remains
and fails right away if another version is installed, with a message
naming the version the run was made for and how to install the
matching dependencies.

The unit and the functional tests are called with `-t` in both the
push and the weekly workflow, so they run for the version their
dependencies have been installed for. The Composer scripts call
PHPUnit directly and have no version to select, so they exclude the
pinned tests of both versions. The check for a supported version has
no group and therefore runs in all of these cases.

The help text of `-t` and the documentation state now that the
option applies to the test suites as well.

The functional tests additionally cover that the extension is
recognized by its Composer package name, and the test for the
extension key now says so in its name.

The change comes from pull request #2107, which was opened from a
fork, and has been reworked for the current state of the... (continued)

129 of 129 relevant lines covered (100.0%)

5.64 hits per line

Jobs
ID Job ID Ran Files Coverage
1 35087656922.1 6
100.0
 GitHub Action Run
Source Files on build 35087656922