TYPO3BestPractices / tea / 35079032948
100%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 6
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
35079032948

push

github

web-flow 
[TASK] Run the functional sqlite tests on a ramdisk (#2326)

The functional sqlite tests write their databases into the working
tree, where they cost disk io during the run and stay behind after
it. The TYPO3 Core test runner mounts that directory as a tmpfs
instead, and so do the extension harnesses this script is aligned
with.

This script had the mount as well. Pull request #1089 dropped the
"uid" option from it, because podman rejected that option at the
time, and pull request #1394 then removed the mount entirely to keep
a "typo3temp" directory from being created in the extension root.
The latter solved the reported problem by dropping the ramdisk
rather than by moving it into the build directory, and the tests
have been writing to disk ever since.

The mount is restored, now below ".Build/public/", so the directory
it needs is the one the test instance uses anyway and nothing
appears in the extension root again.

Which mount options are needed depends on the container binary, so
they are assigned next to the container parameters they belong to.
Docker creates the tmpfs as "root:root" inheriting the mode of its
host mountpoint, while the user parameter passes a user but no
group: at a umask of 0022 the mountpoint comes up 0755, the group
gets read and execute only, and every test fails with "unable to
open database file". Owner and mode address that. Rootless podman
maps the container root to the host user and needs neither, so it
keeps the mode for the rootful case.

The suite takes about 26 seconds without the mount and about 15
seconds with it, with both container binaries, and it no longer
leaves 12 database files behind.

Verified locally with podman and docker, at a umask of 0002 and of
0022 each: 69 tests, 103 assertions, no database errors and no files
left behind in any of the four runs. Shellcheck passes.

Resolves: #2123

Signed-off-by: Stefan Bürk <stefan@buerk.tech>

129 of 129 relevant lines covered (100.0%)

5.64 hits per line

Jobs
ID Job ID Ran Files Coverage
1 35079032948.1 6
100.0
 GitHub Action Run
Source Files on build 35079032948