TYPO3BestPractices / tea / 35077865389
100%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 6
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
35077865389

push

github

web-flow 
[BUGFIX] Force container removal on cleanup (#2324)

The functional tests leave error messages behind when they run with
podman on the GitHub hosted runners, although the tests themselves
pass and the suite reports SUCCESS:

    Error: sending signal to container ...: `crun kill ... 9` failed
    Error: "typo3-best-practices-tea-24056" has associated containers
    with it. Use -f to forcibly delete containers and pods: network
    is being used

`cleanUp()` sent a signal to every container attached to the run's
network and removed the network right afterwards. The database
containers run with `--rm`, so the signal only starts their removal,
and the network removal races it: the network is still in use when
the container has not disappeared yet, and the run has nothing left
to wait for.

The containers are now removed with `rm -f`, which returns once the
container is gone, and the network is removed with `-f` as well. Only
the suites which start a database container are affected, since the
SQLite suite attaches none.

Verified locally with podman 4.9.3 and with docker: the functional
tests on MySQL pass with both, print no error message and leave
neither a container nor the network of the run behind. That podman
version does not produce the reported error, so the local runs only
show the absence of regressions.

Resolves: #2125

Signed-off-by: Stefan Bürk <stefan@buerk.tech>

129 of 129 relevant lines covered (100.0%)

5.64 hits per line

Jobs
ID Job ID Ran Files Coverage
1 35077865389.1 6
100.0
 GitHub Action Run
Source Files on build 35077865389