stacklok / toolhive / 35072086285

71%

Build Type

push

github

Committed by web-flow

Commit Message

fix(vmcp): make the version poll interval per-Server, not a global (#6644)

TestPeriodicStatusReporting_ReactsToVersionChange assigned the
package-level versionPollInterval while marked t.Parallel. Server.Start
reads it for reconcileSessionsOnRegistryChange (#6549) and
periodicStatusReporting reads it for its ticker, so it raced any
parallel test that starts a server -
TestReadinessEndpoint_DynamicMode_CacheNotSynced in practice - and the
detector took several unrelated tests in the package down with it.

Move the override onto Server and read it through s.pollInterval(),
leaving a package-level default. The test now sets it on its own Server
and stays parallel.

This is what session_reconcile.go's doc comment already asks for: the
interval "passed in ... so tests can drive it without mutating shared
state that a parallel test also touches". Start was still handing it the
global.

Dropping t.Parallel would also have fixed the race but trips
paralleltest, and would have left the global mutable for the next test
to trip over.

Coverage Stats

6 of 6 new or added lines in 2 files covered. (100.0%)

15 existing lines in 5 files now uncovered.

81656 of 115505 relevant lines covered (70.69%)

97.34 hits per line