moscajs / aedes-persistence-mongodb / 35066196789

96%

push

github

feat: add cleanIncoming (#93)

* feat: add cleanIncoming to clear QoS 2 dedup state on clean session

aedes-persistence v11 requires cleanIncoming(client): aedes calls it when a
session is discarded (CONNECT with cleanSession), alongside cleanSubscriptions.
Without it the QoS 2 dedup table survives the session and the first colliding
messageId published by the reconnected client is acked but never delivered
(GHSA-p8r9-qf8w-p73r, MQTT-3.1.2-6).

Implemented as a single deleteMany({ clientId }) on the incoming collection.
Both incoming indexes are clientId-prefixed, so it is an IXSCAN, not a COLLSCAN.

* test: assert cleanIncoming only touches the incoming collection

The upstream conformance suite checks that cleanIncoming clears the
client's incoming packets and leaves other clients alone, but it never
looks at the sibling collections. A cleanIncoming that also wiped the
client's outgoing queue passed abstract.js 50/50 -- silent data loss on
every clean-session CONNECT.

This test pins the isolation: outgoing, will, subscriptions and retained
must survive, and another client's incoming packet must too.

177 of 187 branches covered (94.65%)

Branch coverage included in aggregate %.

45 of 45 new or added lines in 2 files covered. (100.0%)

1428 of 1483 relevant lines covered (96.29%)

144.88 hits per line