• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

icerpc / icerpc-csharp / 35063119562
86%

Build:
DEFAULT BRANCH: main
Ran 16 Sep 2026 06:22AM UTC
Jobs 1
Files 274
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

16 Sep 2026 06:18AM UTC coverage: 85.788% (-0.08%) from 85.868%
35063119562

push

github

web-flow
Fix verbatim identifiers in generated service dispatchers (#4963)

A service marked with `[Service]` can fail to compile when an operation
parameter or return value uses a verbatim identifier such as
`cs::identifier("@event")`. Roslyn exposes the name as `event`, and the
service generator emits invalid accesses such as `args.event`.

`cs::identifier` gives the exact C# identifier and the Slice generator
escapes nothing, so `@event` is the only mapping that keeps a Slice
parameter or return member named like a C# keyword. The `[Service]`
generator was the one place that didn't honor it. Supporting it keeps
the name as written, in metadata and docs included, and code on an older
C# version keeps compiling against the same Slice definitions. The
benefit is modest, since callers using named arguments or tuple element
names write `@event` too.

Escape reserved keywords when emitting tuple accesses and qualified type
and namespace names. Contextual keywords are valid identifiers in every
position the generator emits a name, so they stay as is. Keep the
generated source file names free of `@`, which Roslyn rejects in source
hint names.

Fixes #4939.

## Validation

- Service-generator tests: 12 passed, including 5 new compilation cases
covering request/return tuples, streamed returns, and keyword type and
namespace names.
- Slice-generator tests: 215 passed, including an end-to-end invocation
with escaped parameter and return identifiers.
- `git diff --check` passed.

## What's Changed entry

Area: Slice tools

- Fixed service implementations marked with `[Service]` failing to
compile when generated dispatch code references verbatim C# identifiers,
including parameters and return values renamed with `cs::identifier`.

12882 of 15016 relevant lines covered (85.79%)

2804.74 hits per line

Coverage Regressions

Lines Coverage ∆ File
9
90.12
-0.62% IceRpc/Transports/Slic/Internal/SlicConnection.cs
5
88.35
-4.85% IceRpc/Internal/PipeReaderExtensions.cs
2
91.53
-0.11% IceRpc/Internal/IceRpcProtocolConnection.cs
2
77.2
-0.8% IceRpc/Transports/Tcp/Internal/TcpConnection.cs
Jobs
ID Job ID Ran Files Coverage
1 35063119562.1 16 Sep 2026 06:22AM UTC 3799
15.65
GitHub Action Run
Source Files on build 35063119562
  • Tree
  • List 274
  • Changed 204
  • Source Changed 0
  • Coverage Changed 204
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #35063119562
  • f39644a4 on github
  • Prev Build on main (#35028630854)
  • Next Build on main (#35101697867)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc