go-goyave / goyave / 35037628431

97%

master: 97%

Build Type

Pull #296

github

Committed by MaxFreedomPollard

Commit Message

compress: fix quality value of 0 being ignored in getEncoder

`getEncoder` grouped the parsed `Accept-Encoding` values by priority but
never compared that priority to 0, so an encoding the client explicitly
refused with `q=0` was still selected and the response was compressed
with it. The parsed values are sorted by descending priority, so the
zero-priority ones are now split off the end of the slice before the
encoders are matched, and the loop only sees encodings the client
actually accepts. When nothing is left, the middleware passes through
uncompressed.

The wildcard branch used to return the first configured encoder
unconditionally, which returned the rejected encoding for a header such
as `gzip;q=0, *`. It now returns the first configured encoder that the
header did not reject, and nil when every encoder was rejected. That
unconditional `m.Encoders[0]` also panicked with an index out of range
when `Encoders` was empty and the request sent `Accept-Encoding: *`; the
lookup that replaces it returns nil instead.

Pull Request Pull Request #296: compress: fix quality value of 0 being ignored in getEncoder

Coverage Stats

12 of 12 new or added lines in 2 files covered. (100.0%)

3 existing lines in 2 files now uncovered.

5684 of 5851 relevant lines covered (97.15%)

278.29 hits per line