Chia-Network / chia-blockchain / 35020741062

90%

Build Type

push

github

Committed by web-flow

Commit Message

Answer requests for services that are not connected to the daemon instead of dropping them (#21393)

* Answer requests for services that are not connected to the daemon

WebSocketServer.handle_message returned None for a message whose
destination had no registered connection, so the sender never heard
anything: a GUI request for a service that was still starting, or whose
session the daemon had just closed after missed heartbeats, sat until the
client's own timeout (ten minutes in the GUI) with nothing to show why.

Reply to such requests with {"success": False, "error": "<service> is
not connected to the daemon"} addressed to the sender. Replies routed to
a client that has gone (ack messages) and state change broadcasts to
wallet_ui while no UI is connected still get no answer: nothing waits
for those, and answering every broadcast on a headless node would only
make noise.

The GUI already copes with the answer: its service start-up wait pings
the service through the daemon and retries after a second on any
failure, so start-up is unchanged, and an ordinary request now fails
immediately with a message instead of hanging.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TzNNe89x7dm2caSxLWXjZY

* Treat a service whose session was closed as not connected, and keep every broadcast silent

remove_connection() leaves an empty set behind under the service's name,
so `destination in self.connections` stayed true after the daemon closed
a session and the request was forwarded to no socket at all, which is
the very case the reply is for. Forward only when the destination has a
live socket.

Services broadcast state changes to metrics and unfinished_block_info as
well as to wallet_ui. Name the three in one place so a broadcast to any
subscriber that is not connected keeps getting no answer, instead of an
error back to the producing service on every event.

Co-Authored-By: Claude Fable 5.1 <noreply@anthro... (continued)

Coverage Stats

19903 of 24894 branches covered (79.95%)

Branch coverage included in aggregate %.

41 of 41 new or added lines in 2 files covered. (100.0%)

424 existing lines in 41 files now uncovered.

116871 of 126730 relevant lines covered (92.22%)

1.84 hits per line