solidjs / solid / 35015554602

71%

main: 89%

push

github

feat(signals,solid,web,diagnostics): OBSERVE.records — one records channel on both platforms; the call record and its origin (#3472)

* feat(signals,solid,web,diagnostics): OBSERVE.records — one records channel on both platforms; the call record and its origin

The runtimes' records move onto one channel, `OBSERVE.records`, owned by
the core: `subscribe(type, listener)`, `observed(type)`, `emit(type,
event, live)`, created once per process and registered on `globalThis`
under `Symbol.for("@solidjs/signals/observe/records")` so a second copy of
the core (a bundled server build instrumented through `--import`) and
wire layers bundled without a framework import reach the same listener
sets. The catalogue is two empty interfaces the runtimes augment, one
augmenter each: `RecordTypes` (solid-js: `"boundary"`) extends
`HostRecordTypes` (@solidjs/web: `"invocation"`, `"frame"`, `"call"`).
`OBSERVE.server` keeps only the `trace` slot.

The `"frame"` record gains its client half: `FrameEvent` is
`FrameProducedEvent | FrameAppliedEvent`, discriminated by `side`, the
same census on both, the client adding `address` and `outcome:
"truncated"`. The server census is corrected — `regions` counts `html`
chunks addressed to a child frame id (the old count read a chunk type
that does not exist) and `shellMs` is the stream's own shell only.

New `"call"` record: one per server-function call made from the browser,
at the caller's settle — `{ id, at, durationMs, method, outcome, status?,
origin?, deferred? }` with `{ args, response?, result? | error? }` beside
it. It replaces `observeServerFunctionCalls`, which is removed from both
server-function entries. `origin` is what the call ran for, read at
dispatch through the new `OBSERVE.attribution.currentOrigin()` (the
`currentOrigin` hook; the installed hooks are also registered on
`globalThis` under `Symbol.for("@solidjs/signals/observe/attribution")`
for the import-free client): the engine's own `ChangeOrigin` — the
intera... (continued)

520 of 790 branches covered (65.82%)

Branch coverage included in aggregate %.

772 of 1014 relevant lines covered (76.13%)

14.98 hits per line