tari-project / tari / 34956153465

75%

Build Type

push

github

Committed by web-flow

Commit Message

feat(ledger): make the device transport injectable for simulator tests (#8005)

Introduce a `LedgerTransport` seam in `minotari_ledger_wallet_comms` so
that the ledger client can be pointed at a Speculos simulator instead of
at a HID device, and add `minotari_ledger_wallet_comms_testing`, which
implements that seam over the Speculos APDU TCP socket.

What changed
------------

* `ledger_wallet::LedgerTransport` - the trait both `TransportNativeHID`
and the Speculos transport implement. Documented as possibly blocking
indefinitely: several instructions put a review screen up and do not
answer until a human presses a button, so a timeout at any layer would
desynchronise the host from the device rather than cancel anything.
* `ledger_wallet::register_transport` / `clear_registered_transport`,
behind the new, off-by-default `test_transport` feature. With the
feature off the registry does not exist and `Command::execute` is
byte-identical to before.
* `minotari_ledger_wallet_comms_testing::SpeculosTransport` - one
long-lived TCP connection (Speculos serves one at a time), reconnecting
only on failure. A failed exchange is only re-sent when the request
provably never reached the device; a device that answered, or that was
alive when the request went out, is never replayed, because instructions
such as `GetRawSchnorrSignature` consume a device nonce. The
peer-supplied reply length is bounded by `MAX_APDU_REPLY` so a garbage
stream is a legible error, not an OOM abort.
* `LedgerDeviceError::NativeTransport` / `NativeTransportExchange`
renamed to `TransportConnect` / `TransportExchange`, since they are no
longer HID only.

Behaviour change
----------------

`verify_ledger_application` no longer lets a concurrent caller through
unverified. It used to guard its cache with `try_lock`: a second caller
arriving while the first was still talking to the device failed the
`try_lock`, fell through to the trailing `Ok(())`, and went on to use a
device nothing had checke... (continued)

Coverage Stats

70 of 83 new or added lines in 2 files covered. (84.34%)

970 existing lines in 24 files now uncovered.

85576 of 137540 relevant lines covered (62.22%)

458483.69 hits per line