Mellanox / network-operator / 34947970806
64%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 63
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 62.972% (+0.08%) from 62.897%
34947970806

push

github

web-flow 
fix(chart): raise vendored maintenance-operator memory defaults (#3190)

## Summary

Follow-up to
[Mellanox/maintenance-operator#225](https://github.com/Mellanox/maintenance-operator/issues/225)
/ [PR #243](https://github.com/Mellanox/maintenance-operator/pull/243):
network-operator vendors the maintenance-operator chart locally and
still ships `128Mi` / `64Mi`. Parent
`deployment/network-operator/values.yaml` under
`maintenance-operator-chart.operator` also did not pin `resources`, so
installs via network-operator kept the old defaults.

### Changes

- Vendored
`deployment/network-operator/charts/maintenance-operator-chart/values.yaml`:
`limits.memory` `128Mi` → **`256Mi`**, `requests.memory` `64Mi` →
**`192Mi`** (CPU unchanged); helm-docs-style comments on node-count /
Node informer sizing
- Parent `deployment/network-operator/values.yaml`: explicitly set
`maintenance-operator-chart.operator.resources` to the same defaults,
with comments noting (a) scales with node count and (b) top-level
`operator.resources` is the *network* operator and does **not** size
maintenance-operator
- Short sizing/naming note in main `README.md` (Drain Controller) and
vendored chart README values docs

No controller code changes.

Relates to Mellanox/maintenance-operator#225

## Test plan

- [x] `helm lint deployment/network-operator` (pass; icon INFO only)
- [x] `helm template ... --kube-version 1.32.0 --set
maintenanceOperator.enabled=true -s
charts/maintenance-operator-chart/templates/deployment.yaml` shows
`memory: 256Mi` / `192Mi`
- [ ] CI on NVIDIA runners (may need `/ok-to-test` / copy-pr-bot
approval)

5056 of 8029 relevant lines covered (62.97%)

45.2 hits per line

Coverage Regressions

Lines Coverage ∆ File
4
81.2
-1.28% controllers/nicclusterpolicy_controller.go
2
73.43
-0.31% pkg/state/state_ofed.go
2
85.57
-0.52% pkg/state/state_skel.go
Jobs
ID Job ID Ran Files Coverage
1 34947970806.1 63
62.97
GitHub Action Run
Source Files on build 34947970806