kivy / kivy / 34943340058

61%

Build Type

push

github

Committed by web-flow

Commit Message

Fix mouse provider to track multiple simultaneous button drags (#3597) (#8480)

Rebased/reimplemented against current master (this PR predates the
is_double_tap/alt_touch removal and the modifiers/button='all' work
that has since landed).

- self.current_drag is now a dict instead of a single value. When
  disable_multitouch is set, each button gets its own key, so
  multiple buttons can be held and tracked independently. When
  multitouch simulation is enabled, all drags continue to share a
  single 'mt_simulation' key, preserving the existing one-dot-at-a-time
  behavior.
- Fixed a latent bug from the original patch that deleted
  current_drag[touch.button] on release instead of the actual dict
  key used (which is 'mt_simulation' when multitouch is enabled, not
  the raw button name).
- Added regression tests covering simultaneous multi-button tracking
  (disabled) and the single shared slot behavior (enabled), and fixed
  two existing tests that asserted current_drag is None.
- Documented the behavior change in migration.rst.

Coverage Stats

4904 of 13044 branches covered (37.6%)

46 of 46 new or added lines in 2 files covered. (100.0%)

22 existing lines in 8 files now uncovered.

29936 of 49434 relevant lines covered (60.56%)

1.2 hits per line