ben-manes / caffeine / #5784

100%

master: 100%

Build Type

push

github

Committed by ben-manes

Commit Message

keep jcache access extensions across expiry races

A JCache read extends an entry's access expiry in two lock-free writes,
to the native timer and to the wrapper, and "Reschedule jcache access
expiry outside the compute" had put the native timer first. A read that
judged its captured wrapper expired removed it by identity alone, so it
could discard an entry another read had just extended and publish
EXPIRED for it, and any core read between the two writes re-derived the
native deadline from the older wrapper, letting the entry expire early.
The wrapper is written first again, and the expired-read removals in
containsKey, get, getAll and the loading get now require the captured
wrapper to still be expired.

Coverage Stats

4742 of 4802 branches covered (98.75%)

13 of 13 new or added lines in 2 files covered. (100.0%)

6 existing lines in 4 files now uncovered.

9211 of 9225 relevant lines covered (99.85%)

1.0 hits per line