robertdstein / snipergw / 34894629762

98%

main: 98%

Build Type

Pull #99

github

Committed by robertdstein

Commit Message

Construct WinterAPI lazily inside submit_too_winter

Replaces the previous fix (tests/__init__.py monkeypatching
WinterAPI's network-calling methods before test collection) with a
proper fix: winter = WinterAPI() was a module-level singleton, so
merely importing snipergw.submit.winter (pulled in transitively by
several modules) constructed it -- and its __init__ makes an
unguarded network call via check_version(), which just failed a CI
run with a connection timeout.

Moving the instantiation inside submit_too_winter (after the delete
check, so delete=True still short-circuits before any network call)
means importing the module has no side effects at all, and tests
mock the WinterAPI class directly rather than a pre-built singleton.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Pull Request Pull Request #99: Add unit tests for model, paths, run, skymap, and submit modules

Coverage Stats

5 of 5 new or added lines in 4 files covered. (100.0%)

1 existing line in 1 file now uncovered.

345 of 353 relevant lines covered (97.73%)

1.95 hits per line